Refs #4412: using namespace std; not simplified (constructor)#8477
Open
chrchr-github wants to merge 5 commits intocppcheck-opensource:mainfrom
Open
Refs #4412: using namespace std; not simplified (constructor)#8477chrchr-github wants to merge 5 commits intocppcheck-opensource:mainfrom
chrchr-github wants to merge 5 commits intocppcheck-opensource:mainfrom
Conversation
|
danmar
reviewed
Apr 25, 2026
| } | ||
|
|
||
| { | ||
| const char code[] = "using namespace std;\n" |
Collaborator
There was a problem hiding this comment.
I don't know if this is a realistic test case. I get this with g++ for such code:
$ g++ -fsyntax-only 1.cpp
1.cpp:8:1: error: reference to ‘string’ is ambiguous
8 | string foo() {
| ^~~~~~
In file included from /usr/include/c++/15/string:43,
from 1.cpp:2:
/usr/include/c++/15/bits/stringfwd.h:79:33: note: candidates are: ‘typedef class std::__cxx11::basic_string<char> std::string’
79 | typedef basic_string<char> string;
| ^~~~~~
1.cpp:6:6: note: ‘void string()’
6 | void string();
| ^~~~~~
Collaborator
Author
There was a problem hiding this comment.
Yeah, I'll switch the order of declarations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.